From: Prasad J Pandit <pjp@fedoraproject.org>
Date: Thu, 25 Apr 2019 06:35:34 +0000 (+0530)
Subject: qxl: check release info object
X-Git-Tag: v3.1.1~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3be7eb2f47bf71db5f80fcf8750ea395dd5ffdd2;p=thirdparty%2Fqemu.git

qxl: check release info object

When releasing spice resources in release_resource() routine,
if release info object 'ext.info' is null, it leads to null
pointer dereference. Add check to avoid it.

Reported-by: Bugs SysSec <bugs-syssec@rub.de>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-id: 20190425063534.32747-1-ppandit@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit d52680fc932efb8a2f334cc6993e705ed1e31e99)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 9087db5dee3..5ea862baf08 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -776,6 +776,9 @@ static void interface_release_resource(QXLInstance *sin,
     QXLReleaseRing *ring;
     uint64_t *item, id;
 
+    if (!ext.info) {
+        return;
+    }
     if (ext.group_id == MEMSLOT_GROUP_HOST) {
         /* host group -> vga mode update request */
         QXLCommandExt *cmdext = (void *)(intptr_t)(ext.info->id);