From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 1 May 2020 17:24:47 +0000 (+0200)
Subject: r8169: remove "out of memory" error message from rtl_request_firmware
X-Git-Tag: v5.8-rc1~165^2~354^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3bf6ff3cec5d2b1d8185e76c7fae48ff7021ebd0;p=thirdparty%2Flinux.git

r8169: remove "out of memory" error message from rtl_request_firmware

When preparing an unrelated change, checkpatch complained about this
redundant out-of-memory message. Therefore remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 1c2ea75067846..768721d565ae4 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -2507,10 +2507,8 @@ static void rtl_request_firmware(struct rtl8169_private *tp)
 		return;
 
 	rtl_fw = kzalloc(sizeof(*rtl_fw), GFP_KERNEL);
-	if (!rtl_fw) {
-		netif_warn(tp, ifup, tp->dev, "Unable to load firmware, out of memory\n");
+	if (!rtl_fw)
 		return;
-	}
 
 	rtl_fw->phy_write = rtl_writephy;
 	rtl_fw->phy_read = rtl_readphy;