From: Manivannan Sadhasivam Date: Fri, 8 Dec 2023 06:58:47 +0000 (+0530) Subject: scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() X-Git-Tag: v6.8-rc1~119^2~6^2~15 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3bf7ab4ac30c03beecf57c052e87d5a38fb8aed6;p=thirdparty%2Flinux.git scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() Currently, the function returns -EINVAL if algorithm other than AES-256-XTS is requested. But the correct error code is -EOPNOTSUPP. Fix it! Cc: Abel Vesa Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API") Reviewed-by: Abel Vesa Signed-off-by: Manivannan Sadhasivam Link: https://lore.kernel.org/r/20231208065902.11006-3-manivannan.sadhasivam@linaro.org Tested-by: Andrew Halaney # sa8775p-ride Signed-off-by: Martin K. Petersen --- diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index cbb6a696cd979..852179e456f22 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -158,7 +158,7 @@ static int ufs_qcom_ice_program_key(struct ufs_hba *hba, cap = hba->crypto_cap_array[cfg->crypto_cap_idx]; if (cap.algorithm_id != UFS_CRYPTO_ALG_AES_XTS || cap.key_size != UFS_CRYPTO_KEY_SIZE_256) - return -EINVAL; + return -EOPNOTSUPP; if (config_enable) return qcom_ice_program_key(host->ice,