From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Sat, 4 Feb 2017 11:38:17 +0000 (+0200)
Subject: lib-storage: Don't unnecessarily duplicate user's all setting strings
X-Git-Tag: 2.3.0.rc1~2174
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3c2e763ab035567b2081a805648537b27e7cbbcf;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: Don't unnecessarily duplicate user's all setting strings

user->unexpanded_set and user->set have the same life-time, so they can
point to same strings.
---

diff --git a/src/lib-storage/mail-user.c b/src/lib-storage/mail-user.c
index 334ed30c7b..16a72ae9f5 100644
--- a/src/lib-storage/mail-user.c
+++ b/src/lib-storage/mail-user.c
@@ -61,7 +61,7 @@ struct mail_user *mail_user_alloc(const char *username,
 	user->username = p_strdup(pool, username);
 	user->set_info = set_info;
 	user->unexpanded_set = settings_dup(set_info, set, pool);
-	user->set = settings_dup(set_info, set, pool);
+	user->set = settings_dup_with_pointers(set_info, user->unexpanded_set, pool);
 	user->service = master_service_get_name(master_service);
 	user->default_normalizer = uni_utf8_to_decomposed_titlecase;
 	user->session_create_time = ioloop_time;