From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 1 Aug 2018 11:35:51 +0000 (+0200)
Subject: viriscsi: Request more random bits for interface name
X-Git-Tag: v4.6.0~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3c73beebca8f7e5b6802303416e8a96d37dbfbce;p=thirdparty%2Flibvirt.git

viriscsi: Request more random bits for interface name

In virStorageBackendCreateIfaceIQN() the virRandomBits() is
called in order to use random bits to generate random name for
new interface. However, virAsprintf() is expecting 32 bits and we
are requesting only 30.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Pino Toscano <ptoscano@redhat.com>
---

diff --git a/src/util/viriscsi.c b/src/util/viriscsi.c
index 653b4fd932..f00aeb53a7 100644
--- a/src/util/viriscsi.c
+++ b/src/util/viriscsi.c
@@ -221,7 +221,7 @@ virStorageBackendCreateIfaceIQN(const char *initiatoriqn,
 
     if (virAsprintf(&temp_ifacename,
                     "libvirt-iface-%08llx",
-                    (unsigned long long)virRandomBits(30)) < 0)
+                    (unsigned long long)virRandomBits(32)) < 0)
         return -1;
 
     VIR_DEBUG("Attempting to create interface '%s' with IQN '%s'",