From: Ævar Arnfjörð Bjarmason Date: Sun, 28 Mar 2021 02:18:34 +0000 (+0200) Subject: Makefile: add QUIET_GEN to "tags" and "TAGS" targets X-Git-Tag: v2.32.0-rc0~95^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3c80fcb5910eddf9e347e637fce2b6fbc6d7dcbd;p=thirdparty%2Fgit.git Makefile: add QUIET_GEN to "tags" and "TAGS" targets Don't show the very verbose $(FIND_SOURCE_FILES) command on every "make TAGS" invocation. Let's use "generate into temporary and rename to the final file, after seeing the command that generated the output finished successfully" pattern, to avoid leaving a file with an incorrect output generated by a failed command. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- diff --git a/Makefile b/Makefile index f3dc217832..d3274f62b4 100644 --- a/Makefile +++ b/Makefile @@ -2669,12 +2669,14 @@ FIND_SOURCE_FILES = ( \ ) $(ETAGS_TARGET): FORCE - $(RM) $(ETAGS_TARGET) - $(FIND_SOURCE_FILES) | xargs etags -a -o $(ETAGS_TARGET) + $(QUIET_GEN)$(RM) "$(ETAGS_TARGET)+" && \ + $(FIND_SOURCE_FILES) | xargs etags -a -o "$(ETAGS_TARGET)+" && \ + mv "$(ETAGS_TARGET)+" "$(ETAGS_TARGET)" tags: FORCE - $(RM) tags - $(FIND_SOURCE_FILES) | xargs ctags -a + $(QUIET_GEN)$(RM) tags+ && \ + $(FIND_SOURCE_FILES) | xargs ctags -a -o tags+ && \ + mv tags+ tags cscope: $(RM) cscope*