From: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Date: Thu, 7 Jan 2021 13:09:19 +0000 (+0300)
Subject: src: fix resource leak introduced in d4439a6b8
X-Git-Tag: v7.0.0-rc1~69
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3c97cb2cad96176541d90a9f0ff03741c5692e2f;p=thirdparty%2Flibvirt.git

src: fix resource leak introduced in d4439a6b8

@tmp that was copied just above is leaked on plain return.
The issue is found by Coverity.

Patch that inroduced a leak:
d4439a6b8 : src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 2f9081a877..c9f8ffdb56 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -3022,7 +3022,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain,
     ret = VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn,
                                    VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION);
     if (ret < 0)
-        return NULL;
+        goto done;
     if (ret)
         protection = VIR_MIGRATE_CHANGE_PROTECTION;