From: Willy Tarreau <w@1wt.eu>
Date: Wed, 4 Oct 2017 05:48:56 +0000 (+0200)
Subject: CLEANUUP: checks: don't set conn->handle.fd to -1
X-Git-Tag: v1.8-dev3~68
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3cad39452004d74c2364ee19074105c2c02a9bfb;p=thirdparty%2Fhaproxy.git

CLEANUUP: checks: don't set conn->handle.fd to -1

This used to be needed to know whether there was a check in progress a
long time ago (before tcp_checks) but this is not true anymore and even
becomes wrong after the check is reused as conn_init() initializes it
to DEAD_FD_MAGIC.
---

diff --git a/src/checks.c b/src/checks.c
index c2746001dd..539d5cc1bd 100644
--- a/src/checks.c
+++ b/src/checks.c
@@ -2986,8 +2986,6 @@ const char *init_check(struct check *check, int type)
 		return "out of memory while allocating check connection";
 	}
 
-	check->conn->handle.fd = -1; /* no agent in progress yet */
-
 	return NULL;
 }