From: Noah Misch <noah@leadboat.com>
Date: Sat, 3 Dec 2016 20:46:35 +0000 (-0500)
Subject: Remove wrong CloseHandle() call.
X-Git-Tag: REL9_5_6~76
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3cb8bdfef998ad54a88da5d1d9e0af9be3ab79cc;p=thirdparty%2Fpostgresql.git

Remove wrong CloseHandle() call.

In accordance with its own documentation, invoke CloseHandle() only when
directed in the documentation for the function that furnished the
handle.  GetModuleHandle() does not so direct.  We have been issuing
this call only in the rare event that a CRT DLL contains no "_putenv"
symbol, so lack of bug reports is uninformative.  Back-patch to 9.2 (all
supported versions).

Christian Ullrich, reviewed by Michael Paquier.
---

diff --git a/src/port/win32env.c b/src/port/win32env.c
index 7e7fc2b06e9..6ed50e3e6bc 100644
--- a/src/port/win32env.c
+++ b/src/port/win32env.c
@@ -92,7 +92,6 @@ pgwin32_putenv(const char *envval)
 					rtmodules[i].putenvFunc = (PUTENVPROC) GetProcAddress(rtmodules[i].hmodule, "_putenv");
 					if (rtmodules[i].putenvFunc == NULL)
 					{
-						CloseHandle(rtmodules[i].hmodule);
 						rtmodules[i].hmodule = INVALID_HANDLE_VALUE;
 						continue;
 					}