From: Martin Panter <vadmium+py@gmail.com>
Date: Fri, 12 Aug 2016 11:59:52 +0000 (+0000)
Subject: Issue #26741: Clean up subprocess.Popen object in test_poll
X-Git-Tag: v3.6.0a4~27^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3cf0b2515ba8cfc855ac9a56a0b4545372157176;p=thirdparty%2FPython%2Fcpython.git

Issue #26741: Clean up subprocess.Popen object in test_poll
---

diff --git a/Lib/test/test_poll.py b/Lib/test/test_poll.py
index a0a332bdbcb7..6a2bf6ea7b77 100644
--- a/Lib/test/test_poll.py
+++ b/Lib/test/test_poll.py
@@ -125,6 +125,8 @@ class PollTests(unittest.TestCase):
         cmd = 'for i in 0 1 2 3 4 5 6 7 8 9; do echo testing...; sleep 1; done'
         proc = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE,
                                 bufsize=0)
+        proc.__enter__()
+        self.addCleanup(proc.__exit__, None, None, None)
         p = proc.stdout
         pollster = select.poll()
         pollster.register( p, select.POLLIN )
@@ -147,7 +149,6 @@ class PollTests(unittest.TestCase):
                 continue
             else:
                 self.fail('Unexpected return value from select.poll: %s' % fdlist)
-        p.close()
 
     def test_poll3(self):
         # test int overflow