From: Alexandre Oliva <oliva@adacore.com>
Date: Fri, 24 Feb 2023 14:31:05 +0000 (-0300)
Subject: [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
X-Git-Tag: basepoints/gcc-14~878
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3d1d3ece9bc5a1baa2feb4bf231b709c097b8434;p=thirdparty%2Fgcc.git

[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods

g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS variant.  ARM is the only target that overrides
TARGET_CXX_KEY_METHOD_MAY_BE_INLINE.  It's not clear to me which way
the clash between AAPCS and C++ Modules design should be resolved, but
currently it favors AAPCS and thus the test fails, so skip it on
arm_eabi.


for  gcc/testsuite/ChangeLog

	PR c++/105224
	* g++.dg/modules/virt-2_a.C: Skip on arm_eabi.
---

diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C b/gcc/testsuite/g++.dg/modules/virt-2_a.C
index 580552be5a0d..b5050445c3f1 100644
--- a/gcc/testsuite/g++.dg/modules/virt-2_a.C
+++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C
@@ -1,3 +1,6 @@
+// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE,
+// in a way that invalidates this test.
+// { dg-skip-if "!TARGET_CXX_KEY_METHOD_MAY_BE_INLINE" { arm_eabi } } 
 // { dg-module-do run }
 // { dg-additional-options -fmodules-ts }
 export module foo;