From: Laine Stump <laine@redhat.com>
Date: Wed, 12 Feb 2025 01:55:39 +0000 (-0500)
Subject: conf: change qemuDomainDefAddImplicitInputDevice() to return void
X-Git-Tag: v11.2.0-rc1~281
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3d263290df1d62ab290fe14f0c2753f30913af70;p=thirdparty%2Flibvirt.git

conf: change qemuDomainDefAddImplicitInputDevice() to return void

It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/qemu/qemu_postparse.c b/src/qemu/qemu_postparse.c
index e48802191e..ce74d0365f 100644
--- a/src/qemu/qemu_postparse.c
+++ b/src/qemu/qemu_postparse.c
@@ -1090,7 +1090,7 @@ qemuDomainDefBootPostParse(virDomainDef *def,
 }
 
 
-static int
+static void
 qemuDomainDefAddImplicitInputDevice(virDomainDef *def,
                                     virQEMUCaps *qemuCaps)
 {
@@ -1099,8 +1099,6 @@ qemuDomainDefAddImplicitInputDevice(virDomainDef *def,
         virDomainDefMaybeAddInput(def, VIR_DOMAIN_INPUT_TYPE_MOUSE, VIR_DOMAIN_INPUT_BUS_PS2);
         virDomainDefMaybeAddInput(def, VIR_DOMAIN_INPUT_TYPE_KBD, VIR_DOMAIN_INPUT_BUS_PS2);
     }
-
-    return 0;
 }
 
 
@@ -1195,8 +1193,7 @@ qemuDomainDefAddDefaultDevices(virQEMUDriver *driver,
     bool addIOMMU = false;
 
     /* add implicit input devices */
-    if (qemuDomainDefAddImplicitInputDevice(def, qemuCaps) < 0)
-        return -1;
+    qemuDomainDefAddImplicitInputDevice(def, qemuCaps);
 
     /* Add implicit PCI root controller if the machine has one */
     switch (def->os.arch) {