From: Matthias Reichl Date: Wed, 8 Nov 2017 20:03:32 +0000 (+0100) Subject: ASoC: bcm2835: Enforce full symmetry X-Git-Tag: v4.15-rc1~118^2~1^2~8^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3d2b3c707b3f9516d6c183eb1ffbf02a6dc5dc98;p=thirdparty%2Fkernel%2Flinux.git ASoC: bcm2835: Enforce full symmetry bcm2835's configuration registers can't be changed when a stream is running, which means asymmetric configurations aren't supported. Channel and rate symmetry are already enforced by constraints but samplebits had been missed. As hw_params doesn't check for symmetry constraints by itself and just returns success if a stream is running this led to situations where asymmetric configurations were seeming to succeed but of course didn't work because the hardware wasn't configured at all. Fix this by adding the missing samplerate symmetry constraint. Signed-off-by: Matthias Reichl Signed-off-by: Mark Brown --- diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c index f4b778ed350b6..111b4ef7ce35d 100644 --- a/sound/soc/bcm/bcm2835-i2s.c +++ b/sound/soc/bcm/bcm2835-i2s.c @@ -737,7 +737,8 @@ static struct snd_soc_dai_driver bcm2835_i2s_dai = { | SNDRV_PCM_FMTBIT_S32_LE }, .ops = &bcm2835_i2s_dai_ops, - .symmetric_rates = 1 + .symmetric_rates = 1, + .symmetric_samplebits = 1, }; static bool bcm2835_i2s_volatile_reg(struct device *dev, unsigned int reg)