From: Rohan McLure Date: Fri, 25 Nov 2022 03:41:08 +0000 (+1100) Subject: Remove redundant assignment in felem_mul_ref in p521 X-Git-Tag: openssl-3.2.0-alpha1~1646 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3d4dfeb28a5cb944b8300b4cf807e19ab97d04f5;p=thirdparty%2Fopenssl.git Remove redundant assignment in felem_mul_ref in p521 ftmp4 is assigned immediately before receiving the reduced output of the multiplication of ftmp and ftmp3, without being read inbetween these assignments. Remove redundant assignment. Reviewed-by: Hugo Landau Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19766) --- diff --git a/crypto/ec/ecp_nistp521.c b/crypto/ec/ecp_nistp521.c index cc2243a8b33..388ccd06cf1 100644 --- a/crypto/ec/ecp_nistp521.c +++ b/crypto/ec/ecp_nistp521.c @@ -782,7 +782,6 @@ static void felem_inv(felem out, const felem in) felem_reduce(ftmp3, tmp); /* 2^7 - 2^3 */ felem_square(tmp, ftmp3); felem_reduce(ftmp3, tmp); /* 2^8 - 2^4 */ - felem_assign(ftmp4, ftmp3); felem_mul(tmp, ftmp3, ftmp); felem_reduce(ftmp4, tmp); /* 2^8 - 2^1 */ felem_square(tmp, ftmp4);