From: Thomas Weißschuh <thomas@t-8ch.de>
Date: Wed, 11 Jan 2023 18:17:35 +0000 (+0000)
Subject: lib/sysfs: add TODO about removable usb devices
X-Git-Tag: v2.39-rc1~120
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3d59c7660cf47a14734b5f007712810c5d37056c;p=thirdparty%2Futil-linux.git

lib/sysfs: add TODO about removable usb devices

The usage of the "removable" attribute by the USB subsystem is
incorrect.
---

diff --git a/lib/sysfs.c b/lib/sysfs.c
index f325359560..838b9af140 100644
--- a/lib/sysfs.c
+++ b/lib/sysfs.c
@@ -487,6 +487,8 @@ int sysfs_blkdev_is_removable(struct path_cxt *pc)
 {
 	int rc = 0;
 
+	// FIXME usb is not actually removable
+
 	/* check /sys/dev/block/<maj>:<min>/removable attribute */
 	if (ul_path_read_s32(pc, &rc, "removable") == 0)
 		return rc;