From: Sean V Kelley Date: Sat, 21 Nov 2020 00:10:29 +0000 (-0800) Subject: PCI/ERR: Avoid negated conditional for clarity X-Git-Tag: v5.11-rc1~149^2~16^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3d7d8fc78f4b504819882278fcfe10784eb985fa;p=thirdparty%2Flinux.git PCI/ERR: Avoid negated conditional for clarity Reverse the sense of the Root Port/Downstream Port conditional for clarity. No functional change intended. Link: https://lore.kernel.org/r/20201121001036.8560-9-sean.v.kelley@intel.com Tested-by: Jonathan Cameron # non-native/no RCEC Signed-off-by: Sean V Kelley Signed-off-by: Bjorn Helgaas Reviewed-by: Kuppuswamy Sathyanarayanan Acked-by: Jonathan Cameron --- diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index 46a5b84f88427..931e75f2549db 100644 --- a/drivers/pci/pcie/err.c +++ b/drivers/pci/pcie/err.c @@ -159,11 +159,11 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, * Error recovery runs on all subordinates of the bridge. If the * bridge detected the error, it is cleared at the end. */ - if (!(type == PCI_EXP_TYPE_ROOT_PORT || - type == PCI_EXP_TYPE_DOWNSTREAM)) - bridge = pci_upstream_bridge(dev); - else + if (type == PCI_EXP_TYPE_ROOT_PORT || + type == PCI_EXP_TYPE_DOWNSTREAM) bridge = dev; + else + bridge = pci_upstream_bridge(dev); bus = bridge->subordinate; pci_dbg(bridge, "broadcast error_detected message\n");