From: Jules Irenge Date: Wed, 11 Mar 2020 01:09:08 +0000 (+0000) Subject: ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() X-Git-Tag: v5.7-rc1~116^2~6^2~11 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3db1b00f2122bfe259bdb19f7c0bfcaec54568e3;p=thirdparty%2Fkernel%2Flinux.git ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Sparse reports a warning at tscm_hwdep_read_locked() warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock The root cause is the missing annotation at tscm_hwdep_read_locked() Add the missing __releases(&tscm->lock) annotation Signed-off-by: Jules Irenge Acked-by: Takashi Sakamoto Link: https://lore.kernel.org/r/20200311010908.42366-9-jbi.octave@gmail.com Signed-off-by: Takashi Iwai --- diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c index 9801e33e7f2a3..6f38335fe10bf 100644 --- a/sound/firewire/tascam/tascam-hwdep.c +++ b/sound/firewire/tascam/tascam-hwdep.c @@ -17,6 +17,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf, long count, loff_t *offset) + __releases(&tscm->lock) { struct snd_firewire_event_lock_status event = { .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,