From: Fabio Aiuto Date: Wed, 7 Apr 2021 13:49:32 +0000 (+0200) Subject: staging: rtl8723bs: put constant on the right side in if condition X-Git-Tag: v5.13-rc1~173^2~159 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3dc682aed3a188d32eaa7e8a283b7295ea18fd8f;p=thirdparty%2Fkernel%2Flinux.git staging: rtl8723bs: put constant on the right side in if condition fix the following post-commit hook checkpatch warning: WARNING: Comparisons should place the constant on the right side of the test 683: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2204: + if (_SUCCESS != rtw_set_chplan_cmd(padapter, channel_plan_req, 1, 1)) Signed-off-by: Fabio Aiuto Link: https://lore.kernel.org/r/41c98d13d5c74b1329ae125f097b780745cf8246.1617802415.git.fabioaiuto83@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 2392eb2b0458e..2f65162832481 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -2199,7 +2199,7 @@ static int rtw_wx_set_channel_plan(struct net_device *dev, struct adapter *padapter = rtw_netdev_priv(dev); u8 channel_plan_req = (u8)(*((int *)wrqu)); - if (_SUCCESS != rtw_set_chplan_cmd(padapter, channel_plan_req, 1, 1)) + if (rtw_set_chplan_cmd(padapter, channel_plan_req, 1, 1) != _SUCCESS) return -EPERM; return 0;