From: dan <Dan Kennedy>
Date: Thu, 11 Mar 2021 15:57:25 +0000 (+0000)
Subject: Fix a Tcl object leak in test_session.c.
X-Git-Tag: version-3.35.0~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ddc3809bf6148d09ea02345deade44873b9064f;p=thirdparty%2Fsqlite.git

Fix a Tcl object leak in test_session.c.

FossilOrigin-Name: 07150cf15ad36c7fc681a911f66db23d610ddf110a7be7f1fcefbd8750cd135a
---

diff --git a/ext/session/test_session.c b/ext/session/test_session.c
index 7f6cd0eb97..c3898fd860 100644
--- a/ext/session/test_session.c
+++ b/ext/session/test_session.c
@@ -146,7 +146,10 @@ static int SQLITE_TCLAPI test_sql_exec_changeset(
 static int test_tcl_integer(Tcl_Interp *interp, const char *zVar){
   Tcl_Obj *pObj;
   int iVal = 0;
-  pObj = Tcl_ObjGetVar2(interp, Tcl_NewStringObj(zVar, -1), 0, TCL_GLOBAL_ONLY);
+  Tcl_Obj *pName = Tcl_NewStringObj(zVar, -1);
+  Tcl_IncrRefCount(pName);
+  pObj = Tcl_ObjGetVar2(interp, pName, 0, TCL_GLOBAL_ONLY);
+  Tcl_DecrRefCount(pName);
   if( pObj ) Tcl_GetIntFromObj(0, pObj, &iVal);
   return iVal;
 }
diff --git a/manifest b/manifest
index 335346f862..d5fcc85f69 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Bug\sfix\sin\sappendvfs.c:\s\sAdjust\sthe\ssize\sparameter\sfor\nSQLITE_FCNTL_SIZE_HINT\sto\saccount\sfor\sthe\sprefix.
-D 2021-03-11T13:43:29.264
+C Fix\sa\sTcl\sobject\sleak\sin\stest_session.c.
+D 2021-03-11T15:57:25.662
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -457,7 +457,7 @@ F ext/session/sessionstat1.test 218d351cf9fcd6648f125a26b607b140310160184723c266
 F ext/session/sessionwor.test 6fd9a2256442cebde5b2284936ae9e0d54bde692d0f5fd009ecef8511f4cf3fc
 F ext/session/sqlite3session.c a7c5ac1acfe21d94b37921b29b0458d64d022a66b282338eee4aafa9c018cb1c
 F ext/session/sqlite3session.h f53c99731882bf59c7362855cdeba176ce1fe8eeba089e38a8cce0172f8473aa
-F ext/session/test_session.c 93ca965112d2b4d9d669c9c0be6b1e52942a268796050a145612df1eee175ce0
+F ext/session/test_session.c 90ccf1c30c857bd2fb3f6c990163e8f389ddbdbdc7fa5baa2f6f5f287df41c08
 F ext/userauth/sqlite3userauth.h 7f3ea8c4686db8e40b0a0e7a8e0b00fac13aa7a3
 F ext/userauth/user-auth.txt e6641021a9210364665fe625d067617d03f27b04
 F ext/userauth/userauth.c 7f00cded7dcaa5d47f54539b290a43d2e59f4b1eb5f447545fa865f002fc80cb
@@ -1910,7 +1910,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P b7c92e1d08f213865f026d8dbdc4e805fb5c119b7f206506ed06e83a878de657
-R 2f8a1462de1047e3ffc4376afd9ad435
-U drh
-Z 9f896bc562e0aa6269091d041696ca79
+P 41df3bbefd63151f2ddb920066777eab8e07ecfc0edb0f71f9493debe0a4a2c4
+R b666bc7b205c8c86bf444d94812f9f9d
+U dan
+Z 524885d968dca30473cc8b50af6a719f
diff --git a/manifest.uuid b/manifest.uuid
index 4cb6f2a0b3..461fef36d1 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-41df3bbefd63151f2ddb920066777eab8e07ecfc0edb0f71f9493debe0a4a2c4
\ No newline at end of file
+07150cf15ad36c7fc681a911f66db23d610ddf110a7be7f1fcefbd8750cd135a
\ No newline at end of file