From: Karel Zak <kzak@redhat.com>
Date: Thu, 14 Feb 2019 09:41:59 +0000 (+0100)
Subject: wall: remove unnecessary warning
X-Git-Tag: v2.34-rc1~111
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3de236340dbf8f7f6c771798497e500a4fb878e0;p=thirdparty%2Futil-linux.git

wall: remove unnecessary warning

wall(1) may be used in scripts or in pipe. In this case report failed
ttyname() does not make sense, especially if the code does not depend
on on this function.

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1608176
Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/term-utils/wall.c b/term-utils/wall.c
index 48e654ac66..4c49ebaa1b 100644
--- a/term-utils/wall.c
+++ b/term-utils/wall.c
@@ -359,7 +359,6 @@ static char *makemsg(char *fname, char **mvec, int mvecsz,
 		where = ttyname(STDOUT_FILENO);
 		if (!where) {
 			where = "somewhere";
-			warn(_("cannot get tty name"));
 		} else if (strncmp(where, "/dev/", 5) == 0)
 			where += 5;