From: Andrew Burgess <aburgess@redhat.com>
Date: Fri, 29 Dec 2023 09:00:51 +0000 (+0000)
Subject: gdb: add another overload of startswith
X-Git-Tag: gdb-16-branchpoint~955
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3debc0b3480369d13149ea05cdbf61b6acd0ffdc;p=thirdparty%2Fbinutils-gdb.git

gdb: add another overload of startswith

We already have one overload of the startswith function that takes a
std::string_view for both arguments.  A later patch in this series is
going to be improved by having an overload that takes one argument as
a std::string_view and the other argument as a plain 'char *'.

This commit adds the new overload, but doesn't make use of it (yet).
There should be no user visible changes after this commit.
---

diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h
index 23cd40c0207..2fb22916409 100644
--- a/gdbsupport/common-utils.h
+++ b/gdbsupport/common-utils.h
@@ -100,6 +100,16 @@ startswith (std::string_view string, std::string_view pattern)
 	  && strncmp (string.data (), pattern.data (), pattern.length ()) == 0);
 }
 
+/* Version of startswith that takes a string_view for only one of its
+   arguments.  Return true if STR starts with PREFIX, otherwise return
+   false.  */
+
+static inline bool
+startswith (const char *str, const std::string_view &prefix)
+{
+  return strncmp (str, prefix.data (), prefix.length ()) == 0;
+}
+
 /* Return true if the strings are equal.  */
 
 static inline bool