From: Eric Haszlakiewicz <erh+git@nimenees.com>
Date: Sun, 24 Jun 2018 02:10:55 +0000 (-0400)
Subject: Explain why we're not setting the output name for static libraries when on Windows.
X-Git-Tag: json-c-0.14-20200419~118
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3df1f98b4ab52f271dba5e13ec59cf4d1d093e1a;p=thirdparty%2Fjson-c.git

Explain why we're not setting the output name for static libraries when on Windows.
---

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f64e371f..f4f445a7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -121,6 +121,9 @@ add_library(json-c-static
 set_property(TARGET json-c PROPERTY C_STANDARD 99)
 set_property(TARGET json-c-static PROPERTY C_STANDARD 99)
 if (NOT MSVC)
+# Since MS Windows re-uses the .lib suffix for both static libraries
+#  and the "import library" that's needed to actually link against a
+#  dll, we can't use the same name for static and dynamic libs. :(
 set_target_properties(json-c-static PROPERTIES OUTPUT_NAME json-c)
 endif()