From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Tue, 5 Apr 2022 13:29:14 +0000 (+0200)
Subject: MINOR: quic: Add short packet key phase bit values to traces
X-Git-Tag: v2.6-dev5~19
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3dfd4c4b0d9b5780c4e2761c467791e276e3a84d;p=thirdparty%2Fhaproxy.git

MINOR: quic: Add short packet key phase bit values to traces

This is useful to diagnose key update related issues.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index aa388a2e25..e1cdc72e8c 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -348,8 +348,12 @@ static void quic_trace(enum trace_level level, uint64_t mask, const struct trace
 			const SSL *ssl = a4;
 
 			if (pkt) {
-				chunk_appendf(&trace_buf, " pkt@%p el=%c",
-				              pkt, quic_packet_type_enc_level_char(pkt->type));
+				chunk_appendf(&trace_buf, " pkt@%p", pkt);
+				if (pkt->type == QUIC_PACKET_TYPE_SHORT && pkt->data)
+					chunk_appendf(&trace_buf, " kp=%d",
+					              !!(*pkt->data & QUIC_PACKET_KEY_PHASE_BIT));
+				chunk_appendf(&trace_buf, " el=%c",
+				              quic_packet_type_enc_level_char(pkt->type));
 				if (pkt->pnl)
 					chunk_appendf(&trace_buf, " pnl=%u pn=%llu", pkt->pnl,
 					              (unsigned long long)pkt->pn);