From: Alok Tiwari Date: Fri, 17 Oct 2025 19:35:20 +0000 (-0700) Subject: net: phy: micrel: simplify return in ksz9477_phy_errata() X-Git-Tag: v6.19-rc1~170^2~354 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3dfdc98d1dc29d6339fd0551348df0d968fd9ad4;p=thirdparty%2Fkernel%2Flinux.git net: phy: micrel: simplify return in ksz9477_phy_errata() ksz9477_phy_errata function currently assigns the return value of genphy_restart_aneg() to a variable and then immediately returns it err = genphy_restart_aneg(phydev); if (err) return err; return err; This can be simplified by directly returning the function call result, as the intermediate variable and conditional are redundant. Signed-off-by: Alok Tiwari Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20251017193525.1457064-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 79ce3eb6752b6..65994d97c403c 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -2095,11 +2095,7 @@ static int ksz9477_phy_errata(struct phy_device *phydev) return err; } - err = genphy_restart_aneg(phydev); - if (err) - return err; - - return err; + return genphy_restart_aneg(phydev); } static int ksz9477_config_init(struct phy_device *phydev)