From: Avihai Horon <avihaih@nvidia.com>
Date: Tue, 7 Mar 2023 12:54:36 +0000 (+0000)
Subject: vfio/common: Fix error reporting in vfio_get_dirty_bitmap()
X-Git-Tag: v8.0.0-rc0~16^2~16
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3e2413a6520e5b6d8360395b6b423332abfb3362;p=thirdparty%2Fqemu.git

vfio/common: Fix error reporting in vfio_get_dirty_bitmap()

Return -errno instead of -1 if VFIO_IOMMU_DIRTY_PAGES ioctl fails in
vfio_get_dirty_bitmap().

Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/r/20230307125450.62409-2-joao.m.martins@oracle.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index bab83c0e55c..9fc305448fa 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -1335,6 +1335,7 @@ static int vfio_get_dirty_bitmap(VFIOContainer *container, uint64_t iova,
 
     ret = ioctl(container->fd, VFIO_IOMMU_DIRTY_PAGES, dbitmap);
     if (ret) {
+        ret = -errno;
         error_report("Failed to get dirty bitmap for iova: 0x%"PRIx64
                 " size: 0x%"PRIx64" err: %d", (uint64_t)range->iova,
                 (uint64_t)range->size, errno);