From: Haoxiang Li Date: Wed, 26 Feb 2025 08:50:50 +0000 (+0800) Subject: ASoC: codecs: wcd937x: fix a potential memory leak in wcd937x_soc_codec_probe() X-Git-Tag: v6.15-rc1~173^2~4^2~21 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3e330acf4efd63876d673c046cd073a1d4ed57a8;p=thirdparty%2Fkernel%2Flinux.git ASoC: codecs: wcd937x: fix a potential memory leak in wcd937x_soc_codec_probe() When snd_soc_dapm_new_controls() or snd_soc_dapm_add_routes() fails, wcd937x_soc_codec_probe() returns without releasing 'wcd937x->clsh_info', which is allocated by wcd_clsh_ctrl_alloc. Add wcd_clsh_ctrl_free() to prevent potential memory leak. Fixes: 313e978df7fc ("ASoC: codecs: wcd937x: add audio routing and Kconfig") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li Link: https://patch.msgid.link/20250226085050.3584898-1-haoxiang_li2024@163.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c index e8d3fddbc7b1d..ff8bb01edf428 100644 --- a/sound/soc/codecs/wcd937x.c +++ b/sound/soc/codecs/wcd937x.c @@ -2571,6 +2571,7 @@ static int wcd937x_soc_codec_probe(struct snd_soc_component *component) ARRAY_SIZE(wcd9375_dapm_widgets)); if (ret < 0) { dev_err(component->dev, "Failed to add snd_ctls\n"); + wcd_clsh_ctrl_free(wcd937x->clsh_info); return ret; } @@ -2578,6 +2579,7 @@ static int wcd937x_soc_codec_probe(struct snd_soc_component *component) ARRAY_SIZE(wcd9375_audio_map)); if (ret < 0) { dev_err(component->dev, "Failed to add routes\n"); + wcd_clsh_ctrl_free(wcd937x->clsh_info); return ret; } }