From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Fri, 22 Sep 2023 08:43:25 +0000 (+0200)
Subject: Fix formatting and a clang-tidy issue
X-Git-Tag: rec-4.9.2~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ee46818284e31bb2334a797609ea7f767300c25;p=thirdparty%2Fpdns.git

Fix formatting and a clang-tidy issue
---

diff --git a/pdns/recursordist/rec-taskqueue.hh b/pdns/recursordist/rec-taskqueue.hh
index 73eedeeced..13658055c5 100644
--- a/pdns/recursordist/rec-taskqueue.hh
+++ b/pdns/recursordist/rec-taskqueue.hh
@@ -57,4 +57,3 @@ uint64_t getAlmostExpiredTasksRun();
 uint64_t getAlmostExpiredTaskExceptions();
 
 bool taskQTypeIsSupported(QType qtype);
-
diff --git a/pdns/recursordist/recpacketcache.cc b/pdns/recursordist/recpacketcache.cc
index 77dc63e1e1..9f7591b8d9 100644
--- a/pdns/recursordist/recpacketcache.cc
+++ b/pdns/recursordist/recpacketcache.cc
@@ -129,7 +129,7 @@ bool RecursorPacketCache::checkResponseMatches(MapCombo::LockedContent& shard, s
       if (s_refresh_ttlperc > 0 && !iter->d_submitted && taskQTypeIsSupported(qtype)) {
         const dnsheader_aligned header(iter->d_packet.data());
         const auto* headerPtr = header.get();
-        if (headerPtr->rcode == RCode::NoError) {
+        if (headerPtr->rcode == static_cast<unsigned>(RCode::NoError)) {
           const uint32_t deadline = iter->getOrigTTL() * s_refresh_ttlperc / 100;
           const bool almostExpired = ttl <= deadline;
           if (almostExpired) {