From: Frédéric Marchal <fmarchal@users.sourceforge.net>
Date: Sun, 26 Aug 2012 17:40:10 +0000 (+0200)
Subject: Don't keep the % in the URL when converted into a file name
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ee64878154b38784d4920274d906121ecc8bce1;p=thirdparty%2Fsarg.git

Don't keep the % in the URL when converted into a file name

When a file name is manufactured from a URL, the percent sign is removed to
prevent the web server or the browser from requesting a file with a % in
it.

The server or the browser would decode the percent sign if the two
subsequent bytes happened to be a valid hexadecimal byte and would request
the wrong file.
---

diff --git a/util.c b/util.c
index 5e5b885..0c0c243 100644
--- a/util.c
+++ b/util.c
@@ -1849,7 +1849,7 @@ void url_to_file(const char *url,char *file,int filesize)
 	filesize--;
 	skip=0;
 	for(i=0; i<filesize && *url; url++) {
-		if(isalnum(*url) || *url=='-' || *url=='_' || *url=='.' || *url=='%') {
+		if(isalnum(*url) || *url=='-' || *url=='_' || *url=='.') {
 			file[i++]=*url;
 			skip=0;
 		} else {