From: Alan Modra <amodra@gmail.com>
Date: Wed, 7 Feb 2024 01:28:10 +0000 (+1030)
Subject: memory leak in objdump disassemble_section
X-Git-Tag: gdb-15-branchpoint~1042
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ef23ee92631014b6e72e63aa0d6ecc467392546;p=thirdparty%2Fbinutils-gdb.git

memory leak in objdump disassemble_section

	* objdump.c (disassemble_section): Free rel_ppstart on error path.
---

diff --git a/binutils/objdump.c b/binutils/objdump.c
index 49e944b1dfd..7beb221cb2f 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -3795,6 +3795,7 @@ disassemble_section (bfd *abfd, asection *section, void *inf)
     {
       non_fatal (_("Reading section %s failed because: %s"),
 		 section->name, bfd_errmsg (bfd_get_error ()));
+      free (rel_ppstart);
       return;
     }
 
@@ -4075,9 +4076,7 @@ disassemble_section (bfd *abfd, asection *section, void *inf)
     }
 
   free (data);
-
-  if (rel_ppstart != NULL)
-    free (rel_ppstart);
+  free (rel_ppstart);
 }
 
 /* Disassemble the contents of an object file.  */