From: Gert Doering Date: Mon, 29 Jun 2020 18:04:05 +0000 (+0200) Subject: Linux: do not change --txqueuelen OS default if not configured. X-Git-Tag: v2.5_beta1~100 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ef858b3d63c61be2f473a8dc5f1f79fa09a85d8;p=thirdparty%2Fopenvpn.git Linux: do not change --txqueuelen OS default if not configured. Remove default setting of "set txqueuelen to 100". This default dates back to the "pre git" times (before 2005) and might have been beneficial back then - nowadays, the Linux default is 500, and thus reducing(!) txqueuelen by-default can cause TX packet drops on the tun interface, and that's bad for throughput. This is a similar change to commit f0b64e5dc (remove setting of the socket send/receive buffers by default) - similar vintage of the existing code, similar motivation. Note: buffer length can be checked with "ip link show" (qlen NNN) See also: https://ivanvari.com/solving-openvpn-poor-throughput-and-packet-loss/ Signed-off-by: Gert Doering Acked-by: Arne Schwabe Message-Id: <20200629180405.17671-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20160.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 34e2bfd3d..2073b4a66 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -844,9 +844,6 @@ init_options(struct options *o, const bool init_gc) #ifdef ENABLE_FEATURE_TUN_PERSIST o->persist_mode = 1; #endif -#ifdef TARGET_LINUX - o->tuntap_options.txqueuelen = 100; -#endif #ifdef _WIN32 #if 0 o->tuntap_options.ip_win32_type = IPW32_SET_ADAPTIVE;