From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 19 Oct 2023 09:39:03 +0000 (+0200)
Subject: dnsdist: Fix a clang-tidy warning with opcodes
X-Git-Tag: dnsdist-1.9.0-alpha2^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3f5e00d801534ee2b2f3c84be30f3916eed229eb;p=thirdparty%2Fpdns.git

dnsdist: Fix a clang-tidy warning with opcodes
---

diff --git a/pdns/dnscrypt.cc b/pdns/dnscrypt.cc
index 192dcfad18..372329bdfc 100644
--- a/pdns/dnscrypt.cc
+++ b/pdns/dnscrypt.cc
@@ -400,7 +400,7 @@ bool DNSCryptQuery::parsePlaintextQuery(const PacketBuffer& packet)
   }
 
   const dnsheader_aligned dh(packet.data());
-  if (dh->qr || ntohs(dh->qdcount) != 1 || dh->ancount != 0 || dh->nscount != 0 || dh->opcode != Opcode::Query) {
+  if (dh->qr || ntohs(dh->qdcount) != 1 || dh->ancount != 0 || dh->nscount != 0 || static_cast<uint8_t>(dh->opcode) != Opcode::Query) {
     return false;
   }