From: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Date: Wed, 11 Dec 2024 03:08:03 +0000 (+0900)
Subject: i2c: core: fix reference leak in i2c_register_adapter()
X-Git-Tag: v6.13~12^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3f8c4f5e9a57868fa107016c81165686d23325f2;p=thirdparty%2Flinux.git

i2c: core: fix reference leak in i2c_register_adapter()

The reference count of the device incremented in device_initialize() is
not decremented when device_add() fails. Add a put_device() call before
returning from the function.

This bug was found by an experimental static analysis tool that I am
developing.

Fixes: 60f68597024d ("i2c: core: Setup i2c_adapter runtime-pm before calling device_add()")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 7c810893bfa33..75d30861ffe21 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1562,6 +1562,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
 	res = device_add(&adap->dev);
 	if (res) {
 		pr_err("adapter '%s': can't register device (%d)\n", adap->name, res);
+		put_device(&adap->dev);
 		goto out_list;
 	}