From: Glenn Washburn Date: Thu, 6 Mar 2025 06:48:13 +0000 (-0600) Subject: tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3fd163e453b577b6728babe80f8f77c981a67b08;p=thirdparty%2Fgrub.git tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS Fix a regression where qemuopts was mistakenly defaulted to the empty string. This prevents the sending of arbitrary QEMU options to tests, which may be desirable for overriding the machine type. There was a concern that allowing the tester to accept arbitrary options would add headaches for another developer trying to diagnose why a test failed on the testers machine because he could not be sure if any additional options were passed to make the test fail. However, all the options are recorded in the run.sh generated script, so this concern is unwarranted. Fixes: 6d729ced70 (tests/util/grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial QEMU arguments) Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper --- diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 15c5f45a5..dae4ff35a 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -74,7 +74,7 @@ exec_show_error () { work_directory=${WORKDIR:-`mktemp -d "${TMPDIR:-/tmp}/grub-shell.XXXXXXXXXX"`} || exit 1 . "${builddir}/grub-core/modinfo.sh" -qemuopts= +qemuopts=${GRUB_QEMU_OPTS} emuopts= serial_port=com0 serial_null=