From: Costas Argyris <costas.argyris@gmail.com>
Date: Wed, 7 Jun 2023 02:50:07 +0000 (-0600)
Subject: libiberty: writeargv: Simplify function error mode.
X-Git-Tag: basepoints/gcc-15~8541
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3fe017ee79211820ca774f4c87ef86753eeef567;p=thirdparty%2Fgcc.git

libiberty: writeargv: Simplify function error mode.

You are right, this is also a remnant of the old function design
that I completely missed.    Here is the follow-up patch for that.

Thanks for pointing it out.

Costas

On Tue, 6 Jun 2023 at 04:12, Jeff Law <jeffreyalaw@gmail.com> wrote:

    On 6/5/23 08:37, Costas Argyris via Gcc-patches wrote:
    > writeargv can be simplified by getting rid of the error exit mode
    > that was only relevant many years ago when the function used
    > to open the file descriptor internally.
    [ ... ]
    Thanks.  I've pushed this to the trunk.

    You could (as a follow-up) simplify it even further.  There's no need
    for the status variable as far as I can tell.  You could just have the
    final return be "return 0;" instead of "return status;".

libiberty/
	* argv.c (writeargv): Constant propagate "0" for "status",
	simplifying the code slightly.
---

diff --git a/libiberty/argv.c b/libiberty/argv.c
index 1a18b4d88666..c2823d3e4ba8 100644
--- a/libiberty/argv.c
+++ b/libiberty/argv.c
@@ -299,8 +299,6 @@ non-zero if an error occurred while writing to FILE.
 int
 writeargv (char * const *argv, FILE *f)
 {
-  int status = 0;
-
   if (f == NULL)
     return 1;
 
@@ -333,7 +331,7 @@ writeargv (char * const *argv, FILE *f)
       argv++;
     }
 
-  return status;
+  return 0;
 }
 
 /*