From: Tobias Brunner <tobias@strongswan.org>
Date: Thu, 14 Apr 2011 13:09:30 +0000 (+0200)
Subject: Do proper cleanup in some error cases in pki signcrl.
X-Git-Tag: 4.5.2~134
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3fe6c0b27e1e37f28b9e0cc745841b23f4ebf2ac;p=thirdparty%2Fstrongswan.git

Do proper cleanup in some error cases in pki signcrl.
---

diff --git a/src/pki/commands/signcrl.c b/src/pki/commands/signcrl.c
index 4b1c12e5cf..9a21bd99cf 100644
--- a/src/pki/commands/signcrl.c
+++ b/src/pki/commands/signcrl.c
@@ -238,7 +238,8 @@ static int sign_crl()
 				}
 				else
 				{
-					return command_usage( "invalid revocation reason");
+					error = "invalid revocation reason";
+					goto usage;
 				}
 				continue;
 			case 'd':
@@ -252,7 +253,8 @@ static int sign_crl()
 			case 'f':
 				if (!get_form(arg, &form, CRED_CERTIFICATE))
 				{
-					return command_usage("invalid output format");
+					error = "invalid output format";
+					goto usage;
 				}
 				continue;
 			case EOF: