From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 14 Feb 2024 14:25:10 +0000 (+0100)
Subject: revision: clarify a 'return NULL' in get_reference()
X-Git-Tag: v2.45.0-rc0~133^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3ff56af99b1c9becd9e603b59986359f553e62a8;p=thirdparty%2Fgit.git

revision: clarify a 'return NULL' in get_reference()

When we know a pointer variable is NULL, it's clearer to
explicitly return NULL than to return that variable.

In get_reference(), when 'object' is NULL, we already return NULL
when 'revs->exclude_promisor_objects && is_promisor_object(oid)' is
true, but we return 'object' when 'revs->ignore_missing' is true.

Let's make the code clearer and more uniform by also explicitly
returning NULL when 'revs->ignore_missing' is true.

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/revision.c b/revision.c
index 2424c9bd67..4c5cd7c3ce 100644
--- a/revision.c
+++ b/revision.c
@@ -385,7 +385,7 @@ static struct object *get_reference(struct rev_info *revs, const char *name,
 
 	if (!object) {
 		if (revs->ignore_missing)
-			return object;
+			return NULL;
 		if (revs->exclude_promisor_objects && is_promisor_object(oid))
 			return NULL;
 		die("bad object %s", name);