From: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: Sat, 15 Feb 2020 16:15:57 +0000 (+0100)
Subject: hw/block/pflash_cfi02: Remove unneeded variable assignment
X-Git-Tag: v5.0.0-rc0~83^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=400be27f82395ca314ec3731c1a4e86843e4f53f;p=thirdparty%2Fqemu.git

hw/block/pflash_cfi02: Remove unneeded variable assignment

Fix warning reported by Clang static code analyzer:

    CC      hw/block/pflash_cfi02.o
  hw/block/pflash_cfi02.c:311:5: warning: Value stored to 'ret' is never read
      ret = -1;
      ^     ~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200215161557.4077-4-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---

diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 7c4744c020c..12f18d401a8 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -308,7 +308,6 @@ static uint64_t pflash_read(void *opaque, hwaddr offset, unsigned int width)
     hwaddr boff;
     uint64_t ret;
 
-    ret = -1;
     /* Lazy reset to ROMD mode after a certain amount of read accesses */
     if (!pfl->rom_mode && pfl->wcycle == 0 &&
         ++pfl->read_counter > PFLASH_LAZY_ROMD_THRESHOLD) {