From: Stefan Hajnoczi Date: Thu, 10 Oct 2019 12:21:54 +0000 (+0100) Subject: trace: avoid "is" with a literal Python 3.8 warnings X-Git-Tag: v4.2.0-rc0~58^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=403e11edbfad5da2e6d5842adc9222f60e76ee43;p=thirdparty%2Fqemu.git trace: avoid "is" with a literal Python 3.8 warnings The following statement produces a SyntaxWarning with Python 3.8: if len(format) is 0: scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Did you mean "=="? Use the conventional len(x) == 0 syntax instead. Reported-by: Daniel P. Berrangé Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191010122154.10553-1-stefanha@redhat.com> Signed-off-by: Stefan Hajnoczi --- diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 04279fa62e4..44c118bc2ab 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -456,12 +456,12 @@ def generate(events, group, format, backends, import tracetool format = str(format) - if len(format) is 0: + if len(format) == 0: raise TracetoolError("format not set") if not tracetool.format.exists(format): raise TracetoolError("unknown format: %s" % format) - if len(backends) is 0: + if len(backends) == 0: raise TracetoolError("no backends specified") for backend in backends: if not tracetool.backend.exists(backend):