From: Aurelien DARRAGON <adarragon@haproxy.com>
Date: Mon, 18 Sep 2023 15:21:19 +0000 (+0200)
Subject: MINOR: sink: don't rely on forward_px to init sink forwarding
X-Git-Tag: v2.9-dev7~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=405567c12574aaa6b5902c494f4477af8a32c0b2;p=thirdparty%2Fhaproxy.git

MINOR: sink: don't rely on forward_px to init sink forwarding

Instead, we check if at least one sft has been registered into the sink,
if it is the case, then we need to init the forwarding for the sink.
---

diff --git a/src/sink.c b/src/sink.c
index a75cb7ed2b..ae64b5537c 100644
--- a/src/sink.c
+++ b/src/sink.c
@@ -894,10 +894,11 @@ static int sink_finalize(struct sink *sink)
 				sink->sft = sft;
 				srv = srv->next;
 			}
-			if (sink_init_forward(sink) == 0) {
-				ha_alert("error when trying to initialize sink buffer forwarding.\n");
-				err_code |= ERR_ALERT | ERR_FATAL;
-			}
+		}
+		/* init forwarding if at least one sft is registered */
+		if (sink->sft && sink_init_forward(sink) == 0) {
+			ha_alert("error when trying to initialize sink buffer forwarding.\n");
+			err_code |= ERR_ALERT | ERR_FATAL;
 		}
 	}
 	return err_code;