From: Fabiano Rosas <farosas@suse.de>
Date: Wed, 28 Aug 2024 14:56:48 +0000 (-0300)
Subject: migration/multifd: Fix p->iov leak in multifd-uadk.c
X-Git-Tag: v9.2.0-rc0~103^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=405e352d28c24991cacfdebccf67d56c4795cf6e;p=thirdparty%2Fqemu.git

migration/multifd: Fix p->iov leak in multifd-uadk.c

The send_cleanup() hook should free the p->iov that was allocated at
send_setup(). This was missed because the UADK code is conditional on
the presence of the accelerator, so it's not tested by default.

Fixes: 819dd20636 ("migration/multifd: Add UADK initialization")
Reported-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---

diff --git a/migration/multifd-uadk.c b/migration/multifd-uadk.c
index 89f6a72f0e6..6e6a290ae98 100644
--- a/migration/multifd-uadk.c
+++ b/migration/multifd-uadk.c
@@ -132,6 +132,8 @@ static void multifd_uadk_send_cleanup(MultiFDSendParams *p, Error **errp)
 
     multifd_uadk_uninit_sess(wd);
     p->compress_data = NULL;
+    g_free(p->iov);
+    p->iov = NULL;
 }
 
 static inline void prepare_next_iov(MultiFDSendParams *p, void *base,