From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Date: Tue, 21 May 2024 20:17:11 +0000 (-0700)
Subject: drm/xe: Properly handle alloc_guc_id() failure
X-Git-Tag: v6.11-rc1~141^2~26^2~70
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=40672b792a36894aff3a337b695f6136ee6ac5d4;p=thirdparty%2Flinux.git

drm/xe: Properly handle alloc_guc_id() failure

Release the submission_state lock if alloc_guc_id() fails.

v2: Add Fixes tag and CC stable kernel

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: <stable@vger.kernel.org> # v6.8+
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240521201711.4934-1-niranjana.vishwanathapura@intel.com
---

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index b041b7676c086..23f73577facf6 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1317,6 +1317,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
 	return 0;
 
 err_entity:
+	mutex_unlock(&guc->submission_state.lock);
 	xe_sched_entity_fini(&ge->entity);
 err_sched:
 	xe_sched_fini(&ge->sched);