From: dklawren <dklawren@users.noreply.github.com>
Date: Wed, 5 Jun 2019 20:20:34 +0000 (-0400)
Subject: Bug 1556465 - When assigning to self on enter_bug.cgi, the (take) link should be... 
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=406affcb2f1a3842648bed566ea4c6233c65fdee;p=thirdparty%2Fbugzilla.git

Bug 1556465 - When assigning to self on enter_bug.cgi, the (take) link should be a button instead of normal link to be consistent
---

diff --git a/extensions/BMO/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl b/extensions/BMO/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl
index 47d86bd58..aaf934fdb 100644
--- a/extensions/BMO/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl
+++ b/extensions/BMO/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl
@@ -16,7 +16,8 @@
       <td colspan="3">
         <span id="cf_crash_signature_container">
           <span id="cf_crash_signature_nonedit_display"><i>None</i></span>
-          (<a id="cf_crash_signature_action" href="#">edit</a>)
+          <button type="button" class="minor"
+                  id="cf_crash_signature_action">Edit</button>
         </span>
         <span id="cf_crash_signature_input">
           <textarea id="cf_crash_signature" name="cf_crash_signature" rows="4" cols="60"
diff --git a/extensions/UserStory/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl b/extensions/UserStory/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl
index 3ec91ad3c..658ec3ee6 100644
--- a/extensions/UserStory/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl
+++ b/extensions/UserStory/template/en/default/hook/bug/create/create-after_custom_fields.html.tmpl
@@ -16,9 +16,10 @@
     </th>
     <td colspan="3">
       <div id="user_story_header">
-          <span id="user_story_edit">
-            (<a href="javascript:void(0)" id="user_story_edit_action">edit</a>)
-          </span>
+        <span id="user_story_edit">
+          <button type="button" class="minor"
+                  id="user_story_edit_action">Edit</button>
+        </span>
       </div>
       <div id="user_story_edit_container" class="bz_default_hidden">
         [% user_story_default = cloned_bug ? cloned_bug.cf_user_story : default.cf_user_story %]
diff --git a/template/en/default/bug/create/create.html.tmpl b/template/en/default/bug/create/create.html.tmpl
index 85b4fee8c..d7ce09a80 100644
--- a/template/en/default/bug/create/create.html.tmpl
+++ b/template/en/default/bug/create/create.html.tmpl
@@ -415,8 +415,9 @@ TUI_hide_default('expert_fields');
       %]
       [% UNLESS assigned_to_disabled %]
         <span id="take_bug">
-        &nbsp;(<a title="Assign to yourself" href="#"
-                  onclick="return take_bug('[% user.login FILTER js %]')">take</a>)
+          <button title="Assign to yourself"
+                  type="button" class="minor"
+                  onclick="return take_bug('[% user.login FILTER js %]')">Take</button>
         </span>
       [% END %]
       <noscript>(Leave blank to assign to component's default assignee)</noscript>
diff --git a/template/en/default/bug/field.html.tmpl b/template/en/default/bug/field.html.tmpl
index a38a5a07c..d9cc8e7c2 100644
--- a/template/en/default/bug/field.html.tmpl
+++ b/template/en/default/bug/field.html.tmpl
@@ -89,7 +89,8 @@
           [% value FILTER bug_link(value, use_alias => 1) FILTER none %]
         [% END %]
         <span id="[% field.name FILTER html %]_edit_container" class="edit_me bz_default_hidden">
-          (<a href="#" id="[% field.name FILTER html %]_edit_action">edit</a>)
+          <button type="button" class="minor"
+                  id="[% field.name FILTER html %]_edit_action">Edit</button>
         </span>
         <script [% script_nonce FILTER none %]>
         hideEditableField('[% field.name FILTER js %]_edit_container',
@@ -210,7 +211,8 @@
      [% CASE constants.FIELD_TYPE_TEXTAREA %]
        <div id="[% field.name FILTER html %]_edit_container" class="bz_default_hidden">
          <div>
-             (<a href="#" id="[% field.name FILTER html %]_edit_action">edit</a>)
+           <button type="button" class="minor"
+                   id="[% field.name FILTER html %]_edit_action">Edit</button>
          </div>
          [% IF value %]
            <pre class="field_textarea_readonly">[% value FILTER html %]</pre>