From: Takashi Iwai Date: Wed, 16 Aug 2023 06:35:25 +0000 (+0200) Subject: ALSA: hda: cs35l41: Fix the loop check in cs35l41_add_dsd_properties X-Git-Tag: v6.6-rc1~135^2~5^2~62 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=409896794380c1dc0d596bbb9255e583a94d9a00;p=thirdparty%2Fkernel%2Flinux.git ALSA: hda: cs35l41: Fix the loop check in cs35l41_add_dsd_properties model->hid is a pointer, and should be rather NULL-checked in the loop of cs35l41_prop_model_table. Fixes: ef4ba63f12b0 ("ALSA: hda: cs35l41: Support systems with missing _DSD properties") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202308160506.8lCEeFDG-lkp@intel.com/ Link: https://lore.kernel.org/r/20230816063525.23009-1-tiwai@suse.de Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c index 673f23257a097..48dcc3f1ef888 100644 --- a/sound/pci/hda/cs35l41_hda_property.c +++ b/sound/pci/hda/cs35l41_hda_property.c @@ -61,7 +61,7 @@ int cs35l41_add_dsd_properties(struct cs35l41_hda *cs35l41, struct device *physd { const struct cs35l41_prop_model *model; - for (model = cs35l41_prop_model_table; model->hid > 0; model++) { + for (model = cs35l41_prop_model_table; model->hid; model++) { if (!strcmp(model->hid, hid) && (!model->ssid || (cs35l41->acpi_subsystem_id &&