From: Patrick Steinhardt Date: Mon, 6 Nov 2023 10:45:53 +0000 (+0100) Subject: test-bloom: stop setting up Git directory twice X-Git-Tag: v2.43.0-rc1~2^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=40e9136ff641682e2ef739a3dbce03047ed5426f;p=thirdparty%2Fgit.git test-bloom: stop setting up Git directory twice We're setting up the Git directory twice in the `test-tool bloom` helper, once at the beginning of `cmd_bloom()` and once in the local subcommand implementation `get_bloom_filter_for_commit()`. This can lead to memory leaks as we'll overwrite variables of `the_repository` with newly allocated data structures. On top of that it's simply unnecessary. Fix this by only setting up the Git directory once. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano --- diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c index aabe31d724..1281e66876 100644 --- a/t/helper/test-bloom.c +++ b/t/helper/test-bloom.c @@ -40,7 +40,6 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid) { struct commit *c; struct bloom_filter *filter; - setup_git_directory(); c = lookup_commit(the_repository, commit_oid); filter = get_or_compute_bloom_filter(the_repository, c, 1, &settings,