From: Willy Tarreau Date: Tue, 25 Jan 2022 13:51:53 +0000 (+0100) Subject: BUILD: debug/cli: condition test of O_ASYNC to its existence X-Git-Tag: v2.6-dev1~82 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=410942b92a2687f690c886ae1fdc7ad69a3640e0;p=thirdparty%2Fhaproxy.git BUILD: debug/cli: condition test of O_ASYNC to its existence David Carlier reported a build breakage on Haiku since commit 5be7c198e ("DEBUG: cli: add a new "debug dev fd" expert command") due to O_ASYNC not being defined. Ilya also reported it broke the build on Cygwin. It's not that portable and sometimes defined as O_NONBLOCK for portability. But here we don't even need that, as we already condition other flags, let's just ignore it if it does not exist. --- diff --git a/src/debug.c b/src/debug.c index c15c92650f..1a69697e7f 100644 --- a/src/debug.c +++ b/src/debug.c @@ -1075,7 +1075,9 @@ static int debug_iohandler_fd(struct appctx *appctx) case O_NOCTTY: chunk_appendf(&trash, ",O_NOCTTY"); break; case O_TRUNC: chunk_appendf(&trash, ",O_TRUNC"); break; case O_APPEND: chunk_appendf(&trash, ",O_APPEND"); break; +#ifdef O_ASYNC case O_ASYNC: chunk_appendf(&trash, ",O_ASYNC"); break; +#endif #ifdef O_DIRECT case O_DIRECT: chunk_appendf(&trash, ",O_DIRECT"); break; #endif