From: Colin Ian King <colin.king@canonical.com>
Date: Fri, 24 Apr 2020 11:25:54 +0000 (+0200)
Subject: media: cx231xx: remove redundant assignment to variable err
X-Git-Tag: v5.9-rc1~94^2~241
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=414953b4833f2b2024ec46213a75586465acea90;p=thirdparty%2Fkernel%2Flinux.git

media: cx231xx: remove redundant assignment to variable err

The variable err is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c
index b0cd511346542..c5e21785fafe2 100644
--- a/drivers/media/usb/cx231xx/cx231xx-417.c
+++ b/drivers/media/usb/cx231xx/cx231xx-417.c
@@ -1734,7 +1734,7 @@ static void cx231xx_video_dev_init(
 int cx231xx_417_register(struct cx231xx *dev)
 {
 	/* FIXME: Port1 hardcoded here */
-	int err = -ENODEV;
+	int err;
 	struct cx231xx_tsport *tsport = &dev->ts1;
 	struct vb2_queue *q;