From: Michael Tokarev Date: Wed, 30 Mar 2011 12:31:05 +0000 (+0400) Subject: exit if -drive specified is invalid instead of ignoring the "wrong" -drive X-Git-Tag: v0.14.1~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=419f1c3503967d85d304d776a1af85b7780fed80;p=thirdparty%2Fqemu.git exit if -drive specified is invalid instead of ignoring the "wrong" -drive This fixes the problem when qemu continues even if -drive specification is somehow invalid, resulting in a mess. Applicable for both current master and for stable-0.14 (and the same issue exist 0.13 and 0.12 too). The prob can actually be seriuos: when you start guest with two drives and make an error in the specification of one of them, and the guest has something like a raid array on the two drives, guest may start failing that array or kick "missing" drives which may result in a mess - this is what actually happened to me, I did't want a resync at all, and a resync resulted in re-writing (and allocating) a 4TB virtual drive I used for testing, which in turn resulted in my filesystem filling up and whole thing failing badly. Yes it was just testing VM, I experimented with larger raid arrays, but the end result was quite, well, unexpected. Signed-off-by: Michael Tokarev Acked-by: Jes Sorensen Signed-off-by: Kevin Wolf --- diff --git a/vl.c b/vl.c index ed2cdfae421..e392f9b80b3 100644 --- a/vl.c +++ b/vl.c @@ -2066,7 +2066,9 @@ int main(int argc, char **argv, char **envp) HD_OPTS); break; case QEMU_OPTION_drive: - drive_def(optarg); + if (drive_def(optarg) == NULL) { + exit(1); + } break; case QEMU_OPTION_set: if (qemu_set_option(optarg) != 0)