From: bert hubert <bert.hubert@netherlabs.nl>
Date: Thu, 22 Jan 2015 12:02:35 +0000 (+0100)
Subject: we attempted to store string versions of addresses in comboaddress based ringbuffer... 
X-Git-Tag: rec-3.7.0-rc2~55
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=41aacb6a46f97f3316be88dbc36003f88e00427c;p=thirdparty%2Fpdns.git

we attempted to store string versions of addresses in comboaddress based ringbuffer for corrupt queries
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 05a8f00ce8..e6441b0d2e 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -1005,7 +1005,7 @@ DNSPacket *PacketHandler::questionOrRecurse(DNSPacket *p, bool *shouldRecurse)
   if(p->d.qr) { // QR bit from dns packet (thanks RA from N)
     L<<Logger::Error<<"Received an answer (non-query) packet from "<<p->getRemote()<<", dropping"<<endl;
     S.inc("corrupt-packets");
-    S.ringAccount("remotes-corrupt", p->getRemote());
+    S.ringAccount("remotes-corrupt", p->d_remote);
     return 0;
   }
 
@@ -1037,7 +1037,7 @@ DNSPacket *PacketHandler::questionOrRecurse(DNSPacket *p, bool *shouldRecurse)
       if(d_logDNSDetails)
         L<<Logger::Error<<"Received a malformed qdomain from "<<p->getRemote()<<", '"<<p->qdomain<<"': sending servfail"<<endl;
       S.inc("corrupt-packets");
-      S.ringAccount("remotes-corrupt", p->getRemote());
+      S.ringAccount("remotes-corrupt", p->d_remote);
       S.inc("servfail-packets");
       r->setRcode(RCode::ServFail);
       return r;