From: Oleksij Rempel Date: Mon, 9 Dec 2024 13:07:45 +0000 (+0100) Subject: net: usb: lan78xx: Simplify lan78xx_update_reg X-Git-Tag: v6.14-rc1~162^2~245^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=41b774e4f3279a3b3149a36fe27557ecdc72c29c;p=thirdparty%2Fkernel%2Flinux.git net: usb: lan78xx: Simplify lan78xx_update_reg Simplify `lan78xx_update_reg` by directly returning the result of `lan78xx_write_reg`. This eliminates unnecessary checks and improves code readability. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20241209130751.703182-6-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 5d318ff8b33de..442b6ee2dd461 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -674,11 +674,7 @@ static int lan78xx_update_reg(struct lan78xx_net *dev, u32 reg, u32 mask, buf &= ~mask; buf |= (mask & data); - ret = lan78xx_write_reg(dev, reg, buf); - if (ret < 0) - return ret; - - return 0; + return lan78xx_write_reg(dev, reg, buf); } static int lan78xx_read_stats(struct lan78xx_net *dev,