From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Fri, 29 Apr 2022 13:44:52 +0000 (+0000)
Subject: So the race is between setting the new serial to return and the message coming in
X-Git-Tag: auth-4.8.0-alpha0~109^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=41c76595618291f9b69d7e03f3e7d1239cbfe1e9;p=thirdparty%2Fpdns.git

So the race is between setting the new serial to return and the message coming in
Make sure we set the new serial asap
---

diff --git a/regression-tests.auth-py/test_XFRIncomplete.py b/regression-tests.auth-py/test_XFRIncomplete.py
index aef9016f0f..6061d3123f 100644
--- a/regression-tests.auth-py/test_XFRIncomplete.py
+++ b/regression-tests.auth-py/test_XFRIncomplete.py
@@ -24,8 +24,7 @@ class BadXFRServer(object):
         return self._currentSerial
 
     def moveToSerial(self, newSerial):
-        if newSerial == self._currentSerial:
-            print("newSerial == self._currentSerial", file=sys.stderr)
+        if newSerial == self._currentSerial or newSerial == self._targetSerial:
             return False
 
         #if newSerial != self._currentSerial + 1:
@@ -172,6 +171,7 @@ slave-cycle-interval=1
             if currentSerial > serial:
                 raise AssertionError("Expected serial %d, got %d" % (serial, currentSerial))
             if currentSerial == serial:
+                badxfrServer.moveToSerial(serial+1)
                 return
 
             attempts = attempts + 1